[Serializer] Added missing __call to TraceableNormalizer and TraceableSerializer #46511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind doing the same on TraceableSerializer? |
danielburger1337
changed the title
chalasr
approved these changes
May 30, 2022
derrabus
approved these changes
May 30, 2022
carsonbot
changed the title
|
Thank you @danielburger1337. |
|
Could you do the same on TraceableEncoder ? Thank you |
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Added missing
__callmethod to the new TraceableNormalizer and TraceableSerializer.This method was forgotten and breaks custom normalizers that have public methods outside of the NormalizerInterface.
This approach is already being used for TreaceableAuthenticator, TraceableEventDispatcher, LoggingTranslator etc...