The Wayback Machine - https://web.archive.org/web/20220719095848/https://github.com/symfony/symfony/pull/46650
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfilerBundle] Bump http-kernel requirement to ^6.1 #46650

Merged

Conversation

ostrolucky
Copy link
Contributor

@ostrolucky ostrolucky commented Jun 12, 2022

Q A
Branch? 6.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

Since #44483, WebProfilerBundle requires \Symfony\Component\HttpKernel\DataCollector\ConfigDataCollector::hasXdebugInfo, but this feature was added to http-kernel in very same PR. Hence profiler at the moment does not work with http-kernel < 6.1 (when twig strict variables are enabled, which is a default)

fabpot
fabpot approved these changes Jun 12, 2022
@fabpot
Copy link
Member

@fabpot fabpot commented Jun 12, 2022

Thank you @ostrolucky.

@fabpot fabpot merged commit f0247e0 into symfony:6.1 Jun 12, 2022
7 of 8 checks passed
@KvRae
Copy link

@KvRae KvRae commented Jun 13, 2022

Nice !

@fabpot fabpot mentioned this pull request Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants