The Wayback Machine - https://web.archive.org/web/20220719095838/https://github.com/symfony/symfony/pull/46684
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MonologBridge] Fixed support of elasticsearch 7.+ in ElasticsearchLogstashHandler #46684

Merged
merged 1 commit into from Jun 17, 2022

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Jun 15, 2022

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #46667
License MIT
Doc PR

@GromNaN
Copy link
Member

@GromNaN GromNaN commented Jun 15, 2022

Elasticsearch added a "compatibility header" to handle this specific breaking change. We could simply add this header instead of adding an option.
https://www.elastic.co/guide/en/elasticsearch/reference/8.2/rest-api-compatibility.html

@lyrixx
Copy link
Member Author

@lyrixx lyrixx commented Jun 16, 2022

But they will remove the legacy code at some point. isn't?

@derrabus
Copy link
Member

@derrabus derrabus commented Jun 16, 2022

Where would we set the $elasticsearchVersion parameter? Do we need adjustments to MonologBundle as well?

@lyrixx
Copy link
Member Author

@lyrixx lyrixx commented Jun 16, 2022

Where would we set the $elasticsearchVersion parameter? Do we need adjustments to MonologBundle as well?

it's not registred in the MonologBundle. I blogged in the past on how to register it: https://jolicode.com/blog/how-to-visualize-symfony-logs-in-dev-with-elasticsearch-and-kibana

@fabpot
Copy link
Member

@fabpot fabpot commented Jun 17, 2022

Thank you @lyrixx.

@fabpot fabpot merged commit aa49d1c into symfony:4.4 Jun 17, 2022
7 of 9 checks passed
@lyrixx lyrixx deleted the monolog-es branch Jun 17, 2022
@fabpot fabpot mentioned this pull request Jun 26, 2022
@fabpot fabpot mentioned this pull request Jun 26, 2022
@fabpot fabpot mentioned this pull request Jun 26, 2022
@fabpot fabpot mentioned this pull request Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants