The Wayback Machine - https://web.archive.org/web/20220807023524/https://github.com/symfony/symfony/pull/46960
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FrameworkBundle] Fail gracefully when forms use disabled CSRF #46960

Merged
merged 1 commit into from Jul 19, 2022
Merged

[FrameworkBundle] Fail gracefully when forms use disabled CSRF #46960

merged 1 commit into from Jul 19, 2022

Conversation

HeahDude
Copy link
Contributor

@HeahDude HeahDude commented Jul 17, 2022

Q A
Branch? 4.4
Bug fix? kind of
New feature? no
Deprecations? no
Tickets ~
License MIT
Doc PR ~

Relates to symfony/symfony-docs#16973.

Currently with the following config in Symfony demo:

# config/packages/framework.yaml
framework:
    csrf_protection: false
    form:
        csrf_protection: true

we get:

The service "form.type_extension.csrf" has a dependency on a non-existent service "security.csrf.token_manager".

We should consider this PR as a bug fix to make this exception actionable.

@carsonbot carsonbot added this to the 4.4 milestone Jul 17, 2022
@HeahDude HeahDude mentioned this pull request Jul 17, 2022
Open
@HeahDude HeahDude force-pushed the fix/form-csrf-missing-exception branch from 8dc9f33 to fab0d6d Compare Jul 17, 2022
@HeahDude HeahDude changed the title [FrameworkBundle] Fail gracefully when forms uses disabled CSRF [FrameworkBundle] Fail gracefully when forms use disabled CSRF Jul 17, 2022
@chalasr
Copy link
Member

@chalasr chalasr commented Jul 17, 2022

Such DX improvements are usually merged as features AFAIK

@xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 19, 2022

IMO when core DI extension classes or compiler classes fail with a service not found exception fixing them is not a DX enhancement but a real bugfix.

xabbuh
xabbuh approved these changes Jul 19, 2022
View changes
@HeahDude HeahDude force-pushed the fix/form-csrf-missing-exception branch from fab0d6d to 5990182 Compare Jul 19, 2022
xabbuh
xabbuh approved these changes Jul 19, 2022
View changes
fabpot
fabpot approved these changes Jul 19, 2022
View changes
@fabpot
Copy link
Member

@fabpot fabpot commented Jul 19, 2022

Thank you @HeahDude.

@fabpot fabpot merged commit 8e72b1f into symfony:4.4 Jul 19, 2022
9 of 10 checks passed
@HeahDude HeahDude deleted the fix/form-csrf-missing-exception branch Jul 19, 2022
This was referenced Jul 29, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot

@xabbuh xabbuh

@chalasr chalasr

Assignees
No one assigned
Labels
FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@HeahDude @chalasr @xabbuh @fabpot @carsonbot