The Wayback Machine - https://web.archive.org/web/20220807030610/https://github.com/symfony/symfony/pull/47048
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serializer] Fix XmlEncoder encoding attribute false #47048

Merged
merged 1 commit into from Jul 24, 2022
Merged

[Serializer] Fix XmlEncoder encoding attribute false #47048

merged 1 commit into from Jul 24, 2022

Conversation

alamirault
Copy link
Contributor

@alamirault alamirault commented Jul 24, 2022

Q A
Branch? 4.4
Bug fix? no
Deprecations? no
Tickets Fix #47002
License MIT
Doc PR 
[
    'foo' => [
        '@bar' = true,
        '@baz' = false,
    ]
]

Before patch:

<foo bar="1" baz="">

After patch:

<foo bar="1" baz="0">

@alamirault alamirault requested a review from dunglas as a code owner Jul 24, 2022
@carsonbot carsonbot added this to the 4.4 milestone Jul 24, 2022
fabpot
fabpot approved these changes Jul 24, 2022
View changes
@fabpot
Copy link
Member

@fabpot fabpot commented Jul 24, 2022

Thank you @alamirault.

@fabpot fabpot merged commit 6183d66 into symfony:4.4 Jul 24, 2022
8 of 10 checks passed
This was referenced Jul 29, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot

@dunglas dunglas

Assignees
No one assigned
Labels
Serializer Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alamirault @fabpot @carsonbot