please review

Thanks @aminalaee for the patch 👍

I've tested your fix locally and it raises ValueError if the class type doesn't inherit from BaseModel

here is the eaxmple:

from pydantic import BaseModel
from typing import Type

class Test:
    b: int

class TypeTest(BaseModel):
  t: Type[Test]

print(TypeTest.schema())

it will raise

raise ValueError(f'Value not declarable with JSON Schema, field: {field}')
ValueError: Value not declarable with JSON Schema, field: name='t' type=Type[__main__.Test] required=True

please update

Also conflicts, @aminalaee do you think you'll be able to look at this?

Yes if it's not a very high priority I can take a look to fix this.
Otherwise I can close it.

I think best to fix it if you have time 🙏, V1.10 won't be out until earliest the end of the week.

@hramezani I'm not sure how that would be possible since in your example Test does not inherit from BaseModel so there's no way to get the schema from it.
The validation part will not be changed and is already tested in some tests like:

So to my understanding this is the current situation, both validation and schema will work for this:

from pydantic import BaseModel
from typing import Type

class Test(BaseModel):
    a: int

class TypeTest(BaseModel):
  t: Type[Test]

since the Test is inheriting from BaseModel.

But for cases like this which are also mentioned in the docs here, the schema() won't work since there's no way to get the schema, but validation works ok:

from pydantic import BaseModel
from typing import Type

class Test:
    b: int

class TypeTest(BaseModel):
  t: Type[Test]

# Or

class TypeTest(BaseModel):
    t: Type

I guess this has been the behaviour all along.

I think in some issues they are referring to the first case which will be fixed by this like #4051 and #2916 and some the second case which really is a wrong usage (IMO) like #3390

please review

Thanks @aminalaee for your update!

please update.

Thanks for the review, I've changed it to behave as Any I hope this makes sense

Thank so much.