Catch Exceptions in smart_deepcopy #4187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review @samuelcolvin |
|
please update. |
|
LGTM, @coneybeare is this complete? |
|
@samuelcolvin I believe it is, yes |
|
great, thanks so much. In future, it's safest to use the magic comment "please review" to assign the PR to me and make sure I know the PR needs my attention. |
pydantic-hooky
bot
assigned hramezani, PrettyWood and samuelcolvin and unassigned coneybeare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Change Summary
This PR comes from an issue where a
sqlalchemycolumn definition was raising whennot objwas called insmart_deepcopy. Whether or not the raise is warranted is a question forsqlalchemy, but catching the error here and falling back todeepcopyon seems to be a decent approach as a raise of this nature prevents application import and load.Related issue number
Closes #4184
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)