The Wayback Machine - https://web.archive.org/web/20220811010711/https://github.com/symfony/symfony/pull/46594
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Fix XML cache config #46594

Merged
merged 1 commit into from Jun 7, 2022

Conversation

HeahDude
Copy link
Contributor

@HeahDude HeahDude commented Jun 6, 2022

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix symfony-tools/symfony-application#3 (comment)
License MIT
Doc PR ~

The docs currently bypass XML checks because of this, so I propose to consider it a bug fix to remain consistent (ref symfony-tools/symfony-application#3 (comment)), as the other way would imply updating all the docs.

stof
stof approved these changes Jun 7, 2022
fabpot
fabpot approved these changes Jun 7, 2022
@fabpot
Copy link
Member

@fabpot fabpot commented Jun 7, 2022

Thank you @HeahDude.

@fabpot fabpot merged commit 19bd831 into symfony:4.4 Jun 7, 2022
7 of 9 checks passed
@HeahDude HeahDude deleted the fix/cache-xml-config branch Jun 7, 2022
@fabpot fabpot mentioned this pull request Jun 9, 2022
This was referenced Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants