New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT Updated pre commit hooks #23822
MNT Updated pre commit hooks #23822
Conversation
Thank you for the PR!
Please let me know if the versions of these were 'outdated' for a reason.
Versions are pinned for stability. We have many PRs and having contributors updated their .pre-commit-config.yaml
would be another thing to do. We can have a bot to auto update for contributors on PRs, such as https://pre-commit.ci/ but that introduces another layer of complexity.
That being said, the updates in this PR should not change the behavior.
XREF: changelog for flake8
Hi @thomasjpfan, thank you very much for the review! :) I was looking at the point 4 of the Contributing Guide - How to contribute:
Here |
I expect Line 20 in f9fd3b5
which is more prone to formatting changes. Formatting changes from a |
Thanks a lot, merging! |
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Hi,
While setting up my dev environment, I realised that some pre-commit hooks in the
pre-commit-config.yaml
are outdated:flake8
was pointing to Gitlab. It looks like it is permanently moved to Github, and will not be updated in Gitlab anymore: Checklist for moving from GitLab PyCQA/flake8#1290 and Replace gitlab urls PyCQA/flake8#1305I changed the repo link and also updated the version. This is because the contributing page suggests to install latest flake8 (with
pip install flake8
)pre-commit-hooks
. I just found out by runningpre-commit autoupdate
that this was also outdated.Any other comments?
Please let me know if the versions of these were 'outdated' for a reason. In this case, apologies for the PR! I checked previous issues, PRs and docs but I didn't see mentioned anywhere that the versions should stay fixed.
Thanks :)