The Wayback Machine - https://web.archive.org/web/20220918053756/https://github.com/scikit-learn/scikit-learn/pull/24407
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT Fix some broken asv benchmarks #24407

Merged
merged 2 commits into from Sep 9, 2022
Merged

MAINT Fix some broken asv benchmarks #24407

merged 2 commits into from Sep 9, 2022

Conversation

jeremiedbb
Copy link
Member

@jeremiedbb jeremiedbb commented Sep 9, 2022 •
edited

  • tol = -1 is not valid for KMeans
  • default transform_alpha will change soon, so we need to set it explicitly to avoid change of behavior
  • pandas is required by fetch_openml to get the mnist dataset

Also, avoid running flake8 on auto generated files. It will happen if you run the benchmarks locally on your feature branch and then check that it's flake8 compliant before pushing.

@jeremiedbb jeremiedbb added the Quick Review For PRs that are quick to review label Sep 9, 2022
glemaitre
glemaitre approved these changes Sep 9, 2022
View changes
Copy link
Contributor

@glemaitre glemaitre left a comment

LGTM

@glemaitre glemaitre merged commit 79fb69d into scikit-learn:main Sep 9, 2022
17 of 31 checks passed
@glemaitre
Copy link
Contributor

glemaitre commented Sep 9, 2022

Merging since this is quite unrelated to the code base and the benchmark is currently broken :)

glemaitre pushed a commit to glemaitre/scikit-learn that referenced this issue Sep 12, 2022
@jeremiedbb @glemaitre
MAINT Fix some broken asv benchmarks (scikit-learn#24407)
2d8f48c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre

Assignees
No one assigned
Labels
Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeremiedbb @glemaitre