The Wayback Machine - https://web.archive.org/web/20220707065645/https://github.com/github/docs/pull/18833
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add necessary bits to install and enable copilot. #18833

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

georgalis
Copy link

@georgalis georgalis commented Jun 28, 2022

No need to send users down the rabbit hole of how many legacy ways to install vim plugins... Simply direct them to use the new builtin nvim plugin support.

Why:

Closes 19579

What's being changed (if available, include any code snippets, screenshots, or gifs):

add necessary steps to docs

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

No need to send users down the rabbit hole of how many legacy ways to install vim plugins... Simply direct them to use the new builtin nvim plugin support.
@welcome
Copy link

@welcome welcome bot commented Jun 28, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@georgalis georgalis temporarily deployed to preview-env-18833 Jun 28, 2022 Inactive
@github-actions github-actions bot added the triage label Jun 28, 2022
@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jun 28, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
copilot/getting-started-with-github-copilot/getting-started-with-github-copilot-in-neovim.md fpt
ghec
fpt
ghec

@georgalis georgalis temporarily deployed to preview-env-18833 Jun 28, 2022 Inactive
@georgalis
Copy link
Author

@georgalis georgalis commented Jun 28, 2022

Is the failing test working properly? I forked the docs repo to create a pull request which does not contain any new repo reference and my fork is public https://github.com/georgalis/docs yet,

FAIL tests/meta/repository-references.js (17.464 s, 537 MB heap size)
  ● check if a GitHub-owned private repository is referenced › in file content/copilot/getting-started-with-github-copilot/getting-started-with-github-copilot-in-neovim.md

what repository reference does the failing test refer to?

adjust referenced repo from
```
https://github.com/github/copilot.vim.git
```
to
```
https://github.com/github/copilot.vim
```
I'm not sure this makes a difference with regard to `private repositories` if not, perhaps the test should check PUBLIC_REPOS with .git as valid.
@janiceilene
Copy link
Collaborator

@janiceilene janiceilene commented Jun 29, 2022

@georgalis Thanks so much for opening a PR! I'll get this triaged for review

@janiceilene janiceilene added content waiting for review copilot and removed triage labels Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content copilot waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants