New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This warning should be removed - A11y: Media elements must have a <track kind="captions"> #5967
Comments
I agree that it makes sense to remove this check for
However, the same is not true for the corresponding rule for As a side note, I don't read the warning as suggesting you add an empty |
Also note that the Svelte tutorial currently has a compiler warning for missing audio captions. Either the rule should not check audio elements or the tutorial should be updated to resolve the warning. This is also a case where it wouldn't make sense to have captions even if audio captions were supported since it's music only, no speech. |
The one for Svelte tutorial having invalid fake
|
Only to someone familiar enough with the FWIW, I like the solution proposed in this issue better than the proposed solution in mine. |
I agree...I followed this direction and put a |
I opened a PR to remove the warning for audio elements since it's causing the most issues and browsers don't support it. I made sure to note in the PR that it doesn't completely resolve this issue, since there's still some discussion around removing the warning for video elements as well. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
just to chime in here, we are building a custom video conferencing app using AWS chime and svelte. We get this warning when we are using the |
More often than not this warning isn't helpful at all. There are numerous reasons why captions wouldn't make sense + some libraries like hls.js set captions dynamically via Even in one of the official tutorials there's a dummy |
taw commentedFeb 6, 2021
To reproduce. Open svelte repl or any svelte project, add
audio
orvideo
tag:Expected:
What actually happens:
A11y: Media elements must have a <track kind="captions"> (1:0)
Reasons this warning needs to be removed:
<track>
for<audio>
in any way whatsoevertrack
tags are not in any kind of widespread use<track kind="caption">
which linter wants people to addtrack
withoutsrc
- is not even valid according to spec! "The src attribute gives the address of the text track data. The value must be a valid non-empty URL potentially surrounded by spaces. This attribute must be present."alt
attribute onimg
which is meaningfully different from noalt
for historical reasons)The text was updated successfully, but these errors were encountered: