Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
getCiphers() sometimes returns empty array #74
Conversation
getCiphers() sometimes returns empty array. Overriding with a default array in place.
return this.crypto.getCiphers().some(function (name) { return name === cipher; }); | ||
var localCiphers = []; | ||
if (this.crypto.getCiphers().length > 0) { | ||
localCiphers = this.crypto.getCiphers() |
chikeichan
Apr 3, 2019
Thanks for the PR @anistark !
I am not 100% comfortable with this approach as it simply ignore the empty results from getCiphers
and override it with hardcoded values that we are not sure if they are supported, and introduce uncertainty for other users.
I am actually curious why getCiphers
return an empty array. This seems to indicate a configuration problem. Could you share more details on the issues?
Thanks for the PR @anistark !
I am not 100% comfortable with this approach as it simply ignore the empty results from getCiphers
and override it with hardcoded values that we are not sure if they are supported, and introduce uncertainty for other users.
I am actually curious why getCiphers
return an empty array. This seems to indicate a configuration problem. Could you share more details on the issues?
getCiphers() sometimes returns empty array. Overriding with a default array of all available algo in place.
Fix for issue #73