Fix warnings and enable warningsAsError #6385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarekgh
reviewed
Oct 17, 2022
tarekgh
reviewed
Oct 17, 2022
tarekgh
approved these changes
Oct 17, 2022
|
@tarekgh I fixed the |
tarekgh
approved these changes
Oct 17, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6385 +/- ##
==========================================
+ Coverage 68.46% 68.50% +0.04%
==========================================
Files 1165 1165
Lines 246202 246202
Branches 25558 25746 +188
==========================================
+ Hits 168550 168652 +102
+ Misses 70967 70862 -105
- Partials 6685 6688 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ericstj
added a commit
to ericstj/machinelearning
that referenced
this pull request
Oct 19, 2022
* Fix warnings and enable warningsAsError * Fix usage of <inheritdoc/>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This cleans up all warnings in the repo and enables warningAsError so new warnings are not introduced.