Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix grammar in thank-you #676
Open
Conversation
| @@ -31,7 +31,7 @@ public override void ViewDidLoad() | |||
| var sendEmail = new BigButtonElement("Email Support", Octicon.Mail); | |||
| var openIssues = new BigButtonElement("Existing Issues", Octicon.IssueOpened); | |||
|
|
|||
| HeaderView.SubText = "This app is the product of hard work and great suggestions! Thank you to all whom provide feedback!"; | |||
| HeaderView.SubText = "This app is the product of hard work and great suggestions! Thank you to all who provide feedback!"; | |||
This comment has been minimized.
This comment has been minimized.
Rexogamer
Jun 13, 2020
How about:
Suggested change
| HeaderView.SubText = "This app is the product of hard work and great suggestions! Thank you to all who provide feedback!"; | |
| HeaderView.SubText = "This app is the product of hard work and great suggestions! Thank you to all who’ve provided feedback!"; |
This comment has been minimized.
This comment has been minimized.
philipmw
Jun 13, 2020
Author
Hi, Rexogamer. Your suggestion sounds good too, but my goal with this PR is to just fix the who/whom grammar issue. Your change is slightly larger in scope, so I'd prefer to leave it to a separate change.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
philipmw
Jun 13, 2020
Author
Hi, Rexogamer. I am new to this project, so can you please clarify for me. What is your affiliation with this project? Are you offering your opinion in an official capacity, rejecting my current PR?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
philipmw
Jun 14, 2020
Author
Oh, thanks for clarifying. To me, that's the beauty of open source. If you feel it's worthwhile to spend your time on a PR for it, then it is big enough for a PR. :)
cadkins052
commented
Jun 14, 2020
|
I agree
…On Saturday, June 13, 2020, Philip M. White ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In CodeHub.iOS/ViewControllers/Application/SupportViewController.cs
<#676 (comment)>:
> @@ -31,7 +31,7 @@ public override void ViewDidLoad()
var sendEmail = new BigButtonElement("Email Support", Octicon.Mail);
var openIssues = new BigButtonElement("Existing Issues", Octicon.IssueOpened);
- HeaderView.SubText = "This app is the product of hard work and great suggestions! Thank you to all whom provide feedback!";
+ HeaderView.SubText = "This app is the product of hard work and great suggestions! Thank you to all who provide feedback!";
Hi, Rexogamer. I am new to this project, so can you please clarify for me.
What is your affiliation with this project? Are you offering your opinion
in an official capacity, rejecting my current PR?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#676 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMD4GWTNHM22S63FOTVV2T3RWQBRTANCNFSM4N4ZLU3A>
.
|
cadkins052
commented
Jun 14, 2020
|
Thank you
…On Saturday, June 13, 2020, cadkins052 ***@***.***> wrote:
I agree
On Saturday, June 13, 2020, Philip M. White ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In CodeHub.iOS/ViewControllers/Application/SupportViewController.cs
> <#676 (comment)>:
>
> > @@ -31,7 +31,7 @@ public override void ViewDidLoad()
> var sendEmail = new BigButtonElement("Email Support", Octicon.Mail);
> var openIssues = new BigButtonElement("Existing Issues",
Octicon.IssueOpened);
>
> - HeaderView.SubText = "This app is the product of hard work and great
suggestions! Thank you to all whom provide feedback!";
> + HeaderView.SubText = "This app is the product of hard work and great
suggestions! Thank you to all who provide feedback!";
>
> Hi, Rexogamer. I am new to this project, so can you please clarify for
me.
> What is your affiliation with this project? Are you offering your opinion
> in an official capacity, rejecting my current PR?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#676 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/
AMD4GWTNHM22S63FOTVV2T3RWQBRTANCNFSM4N4ZLU3A>
> .
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#676 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMD4GWT4AJNEWZYBRTEOECDRWQ5PNANCNFSM4N4ZLU3A>
.
|
LaPrelle10 left a comment
|
HeaderView.SubText = "This app is the product of hard work and great suggestions! Thank you to all who provide feedback!"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
philipmw commentedJun 13, 2020
No description provided.