feat: Created composite Simpson's numerical integration method #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also created midpoint numerical method for integral approximation |
ayaankhan98
reviewed
Oct 20, 2021
Panquesito7
requested changes
Oct 20, 2021
Panquesito7
added
enhancement
8 tasks
Panquesito7
changed the title
Panquesito7
requested changes
Oct 22, 2021
| #include <iostream> | ||
| #include <cmath> | ||
| #include <cstdlib> | ||
| #include <cassert> | ||
| #include <functional> | ||
| #include <map> |
There was a problem hiding this comment.
Please add a one-line description of what the library/header is for (see the example below).
#include <iostream> /// for IO operations
#include <cassert> /// for assert| * | ||
| * Add sample function by replacing one of the f, g, k, l and the assert | ||
| * | ||
| * @author ggkogkou |
There was a problem hiding this comment.
Suggested change
| * @author ggkogkou | |
| * @author [ggkogkou](https://github.com/ggkogkou) |
| /** | ||
| * @namespace simpson_method | ||
| * @brief Contains the Simpson's method implementation | ||
| */ | ||
| namespace simpson_method{ |
There was a problem hiding this comment.
Suggested change
| /** | |
| * @namespace simpson_method | |
| * @brief Contains the Simpson's method implementation | |
| */ | |
| namespace simpson_method{ | |
| /** | |
| * @namespace numerical_methods | |
| * @brief Numerical algorithms/methods | |
| */ | |
| namespace numerical_methods { | |
| /** | |
| * @namespace simpson_method | |
| * @brief Contains Simpson's method implementation | |
| */ | |
| namespace simpson_method { |
| * @returns the result of the integration | ||
| */ | ||
| double evaluate_by_simpson(int N, double h, double a, std::function<double (double)> func); | ||
| } // simspon_method end |
There was a problem hiding this comment.
Suggested change
| } // simspon_method end | |
| } // namespace simpson_method | |
| } // namespace numerical_methods |
|
I updated documentation and namespace as asked to |
Panquesito7
requested changes
Oct 27, 2021
Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
|
Changes done |
Panquesito7
requested changes
Oct 28, 2021
Panquesito7
requested changes
Oct 28, 2021
Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
|
Done. |
ayaankhan98
requested changes
Oct 31, 2021
There was a problem hiding this comment.
Thanks for your contribution. Please fix the issue below.
test.cpp: In function ‘void test(int, double, double, double, bool)’:
test.cpp:96:87: error: ‘f’ was not declared in this scope; did you mean ‘numerical_methods::simpson_method::f’?
96 | double result_f = numerical_methods::simpson_method::evaluate_by_simpson(N, h, a, f);
| ^
| numerical_methods::simpson_method::f
test.cpp:68:8: note: ‘numerical_methods::simpson_method::f’ declared here
68 | double f(double x){
| ^
test.cpp:100:87: error: ‘g’ was not declared in this scope; did you mean ‘numerical_methods::simpson_method::g’?
100 | double result_g = numerical_methods::simpson_method::evaluate_by_simpson(N, h, a, g);
| ^
| numerical_methods::simpson_method::g
test.cpp:72:8: note: ‘numerical_methods::simpson_method::g’ declared here
72 | double g(double x){
| ^
test.cpp:104:87: error: ‘k’ was not declared in this scope; did you mean ‘numerical_methods::simpson_method::k’?
104 | double result_k = numerical_methods::simpson_method::evaluate_by_simpson(N, h, a, k);
| ^
| numerical_methods::simpson_method::k
test.cpp:76:8: note: ‘numerical_methods::simpson_method::k’ declared here
76 | double k(double x){
| ^
test.cpp:108:87: error: ‘l’ was not declared in this scope; did you mean ‘numerical_methods::simpson_method::l’?
108 | double result_l = numerical_methods::simpson_method::evaluate_by_simpson(N, h, a, l);
| ^
| numerical_methods::simpson_method::l
test.cpp:80:8: note: ‘numerical_methods::simpson_method::l’ declared here
80 | double l(double x){
| ^
shell returned 1
Panquesito7
reviewed
Oct 31, 2021
There was a problem hiding this comment.
Everything else is looking great!
|
Done |
Panquesito7
approved these changes
Nov 1, 2021
Panquesito7
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description of Change
Created the composite Simpson's numerical method for integrals approximation (wiki: https://en.wikipedia.org/wiki/Simpson%27s_rule#Composite_Simpson's_rule).
Checklist
Notes:
Numerical method for integral evaluation implementation