The Wayback Machine - https://web.archive.org/web/20250519212410/https://github.com/TheAlgorithms/C-Plus-Plus/pull/1785
Skip to content

feat: Created midpoint integration numerical method #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Nov 1, 2021
Merged

feat: Created midpoint integration numerical method #1785

merged 38 commits into from
Nov 1, 2021

Conversation

ggkogkou
Copy link
Contributor

@ggkogkou ggkogkou commented Oct 21, 2021 •
edited
Loading

Description of Change

Created midpoint integration numerical method for easy integral approximation.
Tests included (4 functions, integration interval specified).
Correction to the PR #1773

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
Numerical method. Separated this from PR #1773 to match the repositories demands. Participating on hacktoberfest.

Panquesito7
Panquesito7 requested changes Oct 22, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! Thank you for submitting a PR! 😄 Sadly, the documentation is not up to our standards. Please update the file accordingly. Let us know if you need any help here or in our Discord server. 😃

@Panquesito7 Panquesito7 added awaiting modification Do not merge until modifications are made enhancement New feature or request Proper Documentation Required requested to write the documentation properly requested changes changes have been requested labels Oct 22, 2021
@ggkogkou
Copy link
Contributor Author

Updated documentation to match the standards

@ggkogkou ggkogkou requested a review from Panquesito7 October 22, 2021 21:47
@Panquesito7 Panquesito7 changed the title Created midpoint integration numerical method feat: Created midpoint integration numerical method Oct 27, 2021
Panquesito7
Panquesito7 requested changes Oct 27, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 😄👍
Please enable GitHub Actions in your repository of this fork in this link: https://github.com/ggkogkou/C-Plus-Plus/actions

numerical_methods/midpoint_integral_method.cpp Outdated
// Find the step
h = (b-a)/N;

test(N, h, a, b, used_argv_parameters); /// run self-test implementations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test(N, h, a, b, used_argv_parameters); /// run self-test implementations
test(N, h, a, b, used_argv_parameters); // run self-test implementations

@Panquesito7 Panquesito7 removed awaiting modification Do not merge until modifications are made Proper Documentation Required requested to write the documentation properly labels Oct 27, 2021
@ggkogkou
Copy link
Contributor Author

Done.

@ggkogkou ggkogkou requested a review from Panquesito7 October 28, 2021 09:31
@ggkogkou
Copy link
Contributor Author

Done

@ggkogkou ggkogkou requested a review from Panquesito7 October 29, 2021 14:18
Panquesito7
Panquesito7 approved these changes Oct 31, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! You've done amazing work, and it's been your
first contribution here! We hope you keep contributing! 😄👍🎉

After this PR is merged, you can ask for the
contributor role in our Discord server! 🚀

@Panquesito7 Panquesito7 added approved Approved; waiting for merge and removed requested changes changes have been requested labels Oct 31, 2021
aminoxix
aminoxix previously approved these changes Oct 31, 2021
View reviewed changes
Panquesito7
Panquesito7 requested changes Oct 31, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix the CodeQL warnings here?
Let us know if you need any help here or in our Discord server. 😃

@ggkogkou
Copy link
Contributor Author

Done

Panquesito7
Panquesito7 approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Please review @ayaankhan98, @mishraabhinn, and @Amino19. Thanks. 🙂

ayaankhan98
ayaankhan98 approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@ayaankhan98 ayaankhan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution.

@Panquesito7 Panquesito7 merged commit 8a6f205 into TheAlgorithms:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayaankhan98 ayaankhan98 ayaankhan98 approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@aminoxix aminoxix aminoxix approved these changes

@mishraabhinn mishraabhinn Awaiting requested review from mishraabhinn

Assignees
No one assigned
Labels
approved Approved; waiting for merge enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggkogkou @ayaankhan98 @Panquesito7 @aminoxix