The Wayback Machine - https://web.archive.org/web/20221130125258/https://github.com/NativeScript/NativeScript/pull/10047
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: standardized unit testing with jest #10047

Merged
merged 21 commits into from Nov 28, 2022
Merged

Conversation

NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Oct 2, 2022

PR Checklist

What is the current behavior?

Unit tests were awkward to work with and maintain.

What is the new behavior?

Unit tests are now easy to work with, use and maintain.

@cla-bot cla-bot bot added the cla: yes label Oct 2, 2022
@NathanWalker NathanWalker marked this pull request as draft Oct 2, 2022
@NathanWalker NathanWalker force-pushed the feat/standardized-unit-tests branch from e093c4d to 2e64809 Compare Oct 4, 2022
@NathanWalker NathanWalker force-pushed the feat/standardized-unit-tests branch from 3e21499 to 1618c7b Compare Nov 13, 2022
Copy link
Member

@rigor789 rigor789 left a comment

Looks great, noted a few questions here&there...

package.json Outdated Show resolved Hide resolved
packages/core/color/color-common.ts Outdated Show resolved Hide resolved
packages/core/css/parser.spec.ts Outdated Show resolved Hide resolved
packages/core/css/parser.spec.ts Outdated Show resolved Hide resolved
},
extensionsToTreatAsEsm: ['.ts'],
moduleDirectories: ['node_modules'],
moduleFileExtensions: ['ts', 'js', 'ios.ts'],
Copy link
Member

@rigor789 rigor789 Nov 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we could run the whole test-suite twice, once against .ios.ts and once against .android.ts to cover all files...

Copy link
Contributor Author

@NathanWalker NathanWalker Nov 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for mentioning yes I am wanting to do this. Was considering two different configs and .spec.json that could be run independently for this.

packages/core/global-types.d.ts Outdated Show resolved Hide resolved
@NathanWalker NathanWalker marked this pull request as ready for review Nov 28, 2022
@NathanWalker NathanWalker merged commit 86dad3c into main Nov 28, 2022
1 of 2 checks passed
@NathanWalker NathanWalker deleted the feat/standardized-unit-tests branch Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants