gh-99619: fix error in documentation of ExceptionGroup.derive() #99621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
added
type-bug
AlexWaygood
reviewed
Nov 20, 2022
JelleZijlstra
reviewed
Nov 20, 2022
JelleZijlstra
reviewed
Nov 20, 2022
Co-authored-by: Jelle Zijlstra <[email protected]>
JelleZijlstra
reviewed
Nov 20, 2022
Doc/library/exceptions.rst
Outdated
| ... | ||
| >>> match, rest = exc.split(ValueError) | ||
| >>> exc, exc.__context__, exc.__cause__, exc.__notes__, id(exc.__traceback__) | ||
| (MyGroup('eg', [ValueError(1), TypeError(2)]), Exception('context'), Exception('cause'), ['a note'], 4395554432) |
There was a problem hiding this comment.
I don't like including the id(), since ideally we'd run these examples as doctests and obviously the id() isn't gong to stay the same. Maybe instead have a line assert exc.__traceback__ is match.__traceback__ is rest.__traceback__?
JelleZijlstra
approved these changes
Nov 20, 2022
|
Thanks @iritkatriel for the PR |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 23, 2022
…pythonGH-99621) (cherry picked from commit 5d9183c) Co-authored-by: Irit Katriel <[email protected]>
|
GH-99720 is a backport of this pull request to the 3.11 branch. |
miss-islington
added a commit
that referenced
this pull request
Nov 23, 2022
…9621) (cherry picked from commit 5d9183c) Co-authored-by: Irit Katriel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #99619.