Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
chore: first stage of rewriting animations #9892
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/core/color/color-common.ts # packages/core/color/index.d.ts
# Conflicts: # .eslintrc.json # packages/core/bundle-entry-points.ts # packages/core/ui/core/bindable/index.ts # packages/core/ui/styling/style-scope.ts # packages/core/xml/index.ts # packages/webpack5/src/configuration/base.ts # packages/webpack5/src/helpers/index.ts
allow Color constructor to take hsl/hsv
This causes unecessary `requestLayout`
# Conflicts: # apps/automated/package.json # apps/toolbox/package.json # apps/ui/package.json # package.json # packages/core/application/index.android.ts # packages/core/application/index.ios.ts # packages/core/package.json # packages/core/platforms/android/native-api-usage.json # packages/core/platforms/ios/TNSWidgets.xcframework/Info.plist # packages/core/platforms/ios/TNSWidgets.xcframework/ios-arm64/TNSWidgets.framework/TNSWidgets # packages/core/platforms/ios/TNSWidgets.xcframework/ios-arm64/dSYMs/TNSWidgets.framework.dSYM/Contents/Resources/DWARF/TNSWidgets # packages/core/platforms/ios/TNSWidgets.xcframework/ios-arm64_x86_64-maccatalyst/TNSWidgets.framework/Versions/A/Resources/Info.plist # packages/core/platforms/ios/TNSWidgets.xcframework/ios-arm64_x86_64-maccatalyst/TNSWidgets.framework/Versions/A/TNSWidgets # packages/core/platforms/ios/TNSWidgets.xcframework/ios-arm64_x86_64-maccatalyst/dSYMs/TNSWidgets.framework.dSYM/Contents/Resources/DWARF/TNSWidgets # packages/core/platforms/ios/TNSWidgets.xcframework/ios-arm64_x86_64-simulator/TNSWidgets.framework/TNSWidgets # packages/core/ui/text-base/text-base-common.ts # packages/webpack/package.json # packages/webpack/project.json
…an N parent We can do this on both platforms. I could prevent memory leaks
# Conflicts: # packages/core/package.json
It could prevent errors when the client would be called while the runtime is dead NativeScript/android#1667
…change/augment delegates. also unset delegates in disposeNativeView to prevent memory leak
# Conflicts: # packages/core/ui/animation/animation-common.ts # packages/core/ui/animation/index.ios.ts # packages/core/ui/core/view/index.ios.ts # packages/core/ui/gestures/index.ios.ts # packages/core/ui/page/index.ios.ts # packages/core/ui/styling/style-scope.ts # packages/core/ui/text-base/index.ios.ts
…_rebuilt # Conflicts: # packages/core/ui/animation/index.android.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is a draft of rewriting the Animation system in N:
Animationunaware of which properties can be animatedbackgroundColor(which means going back to JS in every single animation step!)autosizeUIViewPropertyAnimator. My issue right now is how to animate custom properties like text color.TODO:
Viewsubclass to define custom property animation handlingCSSPropertyandCSSAnimationProperty? have to figure out the real difference between the 2 as there is no inheritance :s Merging would allow any prop to be animated through css