The Wayback Machine - https://web.archive.org/web/20210112001412/https://github.com/cpp-netlib/cpp-netlib/pull/873
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIN32\CMAKE_FIND_LIBRARY_SUFFIXES not set properly during CPP-NETLIB_STATIC_OPENSSL build #873

Merged
merged 1 commit into from May 29, 2019

Conversation

@rpriest1260
Copy link

@rpriest1260 rpriest1260 commented May 28, 2019

The library suffix is not set correctly when building with CPP-NETLIB_STATIC_OPENSSL on a
Windows Machine. Adding a 'If (WIN32)' condition to properly set
CMAKE_FIND_LIBRARY_SUFFIXES to '.lib' on a windows machine.

the lib suffixes when building with CPP-NETLIB_STATIC_OPENSSL on a
Windows Machine. Adding an 'If (WIN32)' condition to properly set
CMAKE_FIND_LIBRARY_SUFFIXES to '.lib' on a windows machine.
@glynos
Copy link
Member

@glynos glynos commented May 29, 2019

LGTM

@glynos glynos merged commit 7cbd52c into cpp-netlib:master May 29, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@glynos glynos self-assigned this May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.