The Wayback Machine - https://web.archive.org/web/20210112001413/https://github.com/cpp-netlib/cpp-netlib/pull/886
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failed for cxxopt submodule updating #886

Merged
merged 1 commit into from May 8, 2020

Conversation

@jinyuqi
Copy link

@jinyuqi jinyuqi commented May 8, 2020

This patch fix the build issue when cxxopts submodule updated. We should use OptionResults(ParseResults) instead of Options to finish httplclient's building

Copy link
Member

@deanberris deanberris left a comment

LGTM, thanks!

@deanberris deanberris merged commit 69d2c11 into cpp-netlib:master May 8, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.