Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Add clear_resolved_cache implementation #893
Open
Conversation
| @@ -36,18 +36,21 @@ struct async_resolver : std::enable_shared_from_this<async_resolver<Tag> > { | |||
| typedef std::function<void(resolver_type &, string_type, std::uint16_t, | |||
| resolve_completion_function)> resolve_function; | |||
|
|
|||
| void clear_resolved_cache() { clear_cache_ = true; } | |||
deanberris
Jan 11, 2021
Member
You probably want to make clear_cache_ an std::atomic<bool> so that it's thread-safe to modify it from different threads.
You probably want to make clear_cache_ an std::atomic<bool> so that it's thread-safe to modify it from different threads.
| if (clear_cache_) { | ||
| clear_cache_ = false; | ||
| endpoint_cache_.clear(); | ||
| } |
deanberris
Jan 11, 2021
Member
This will have to change if you use an std::atomic<bool> to reset the value to false. Something like:
if (clear_cache_.exchange(false)) {
endpoint_cache_.clear()
}
This will have to change if you use an std::atomic<bool> to reset the value to false. Something like:
if (clear_cache_.exchange(false)) {
endpoint_cache_.clear()
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
basic_client_facadewrite aclear_resolved_cache()but no functions are implemented with pimpl. Add implementation for async_resolver and sync_resolver.