gh-100257: summarize_stats: Link failure kinds to GitHub search #100258
Conversation
By adding links to each row in the failure kind table, we can find where in the code that failure kind has been collected by the specialization code.
|
| Name | Link |
|---|---|
| 4fa35fc | |
| https://app.netlify.com/sites/python-cpython-preview/deploys/639a53fe49fdf6000894537a |
|
It looks like this:
Sample search result: array int. |
|
That link returns a page with "We couldn’t find any code matching 'repo:python/cpython path:Python/specialize.c SPEC_FAIL_SUBSCR_ARRAY_INT' ". Since this can produce misleading search results for branches other than main, it is likely to be counter productive for experimental stats and changes to the stat names. |
Hmm, it works for me.
That could be resolved since we know the hash of the Python that produced it, we could include that in the search URL, if GitHub search supports such a thing. That would make them "permanent" in a sense. IMHO, this is better than nothing despite that issue -- it is hard to know what these snippets of text refer to. Perhaps better (but obviously more work) would be to document them. |
This link? |
|
I'm not sure linking to the source for the macro is going to help clarify stuff. |
By adding links to each row in the failure kind table, we can find where in the code that failure kind has been collected by the specialization code. Search is performed only in
specialize.cin thepython/cpythonrepo (the script is unaware of forks at the moment).