The Wayback Machine - https://web.archive.org/web/20230403083218/https://github.com/python/cpython/issues/100342
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing NULL check in AC *args tuple parsing #100342

Closed
kumaraditya303 opened this issue Dec 19, 2022 · 1 comment · Fixed by #100568
Closed

Missing NULL check in AC *args tuple parsing #100342

kumaraditya303 opened this issue Dec 19, 2022 · 1 comment · Fixed by #100568
Assignees
@kumaraditya303
Labels
3.11 bug and security fixes 3.12 new features, bug and security fixes expert-argument-clinic type-bug An unexpected behavior, bug, or error type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Dec 19, 2022 •
edited by bedevere-bot

__clinic_args is currently not checked for NULL and can crash the interpreter. The fix is to check for NULL and exit early.

Linked PRs
@kumaraditya303 kumaraditya303 added type-bug An unexpected behavior, bug, or error 3.11 bug and security fixes 3.10 bug and security fixes type-crash A hard crash of the interpreter, possibly with a core dump expert-argument-clinic 3.12 new features, bug and security fixes labels Dec 19, 2022
@kumaraditya303 kumaraditya303 self-assigned this Dec 19, 2022
@kumaraditya303
Copy link
Contributor Author

cc @erlend-aasland

@bedevere-bot bedevere-bot mentioned this issue Dec 19, 2022
Merged
@kumaraditya303 kumaraditya303 removed the 3.10 bug and security fixes label Dec 19, 2022
kumaraditya303 added a commit that referenced this issue Dec 28, 2022
@kumaraditya303
GH-100342: check for allocation failure in AC *args parsing (#100343)
7cf164a
@bedevere-bot bedevere-bot mentioned this issue Dec 28, 2022
Merged
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this issue Dec 28, 2022
@kumaraditya303
[3.11] pythonGH-100342: check for allocation failure in AC *args pa…
6ebbf81 
…rsing (pythonGH-100343).

(cherry picked from commit 7cf164a)

Co-authored-by: Kumar Aditya <[email protected]>
@kumaraditya303 kumaraditya303 linked a pull request Dec 28, 2022 that will close this issue
[3.11] GH-100342: check for allocation failure in AC *args parsing (GH-100343). #100568
Merged
kumaraditya303 added a commit that referenced this issue Dec 28, 2022
@kumaraditya303
[3.11] GH-100342: check for allocation failure in AC *args parsing (G…
ebe4288 
…H-100343). (#100568)

(cherry picked from commit 7cf164a)

Co-authored-by: Kumar Aditya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumaraditya303 kumaraditya303

Labels
3.11 bug and security fixes 3.12 new features, bug and security fixes expert-argument-clinic type-bug An unexpected behavior, bug, or error type-crash A hard crash of the interpreter, possibly with a core dump
Projects
None yet
Milestone
No milestone
1 participant
@kumaraditya303