The Wayback Machine - https://web.archive.org/web/20221223144513/https://github.com/python/cpython/pull/99803/commits
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-89727: Fix os.walk RecursionError on deep trees #99803

Merged
merged 16 commits into from Dec 19, 2022
Merged

gh-89727: Fix os.walk RecursionError on deep trees #99803

merged 16 commits into from Dec 19, 2022
+139 −83

Commits on Dec 15, 2022

  1. pythongh-89727: Fix os.walk RecursionError on deep trees 

    Use a stack to implement os.walk iteratively instead of recursively to
avoid hitting recursion limits on deeply nested trees.
    @jonburdo
    jonburdo committed Dec 15, 2022
    99f4691

Commits on Dec 16, 2022

  1. add unit test to ensure os.walk is not affect by recursion limit

    @jonburdo
    jonburdo committed Dec 16, 2022
    3552d49

  2. move os._walk code to os.walk

    @jonburdo
    jonburdo committed Dec 16, 2022
    3078ea6

  3. fix blurb to mention os.walk

    @jonburdo
    jonburdo committed Dec 16, 2022
    f37bbe8

  4. use deque in os.walk

    @jonburdo
    jonburdo committed Dec 16, 2022
    f26a5b8

  5. Merge branch 'main' into iterative-os-walk

    @jonburdo
    jonburdo committed Dec 16, 2022
    955d21b

  6. Merge branch 'main' into iterative-os-walk

    @jonburdo
    jonburdo committed Dec 16, 2022
    8fbfb2e

  7. move deque import inside os.walk

    @jonburdo
    jonburdo committed Dec 16, 2022
    ef46eda

  8. rename temp_recursion_limit to set_recursion_limit

    @jonburdo
    jonburdo committed Dec 16, 2022
    e261b9f

  9. Merge branch 'main' into iterative-os-walk

    @jonburdo
    jonburdo committed Dec 16, 2022
    5ec53f7

  10. switch back to list instead of deque for os.walk stack

    @jonburdo
    jonburdo committed Dec 16, 2022
    507b650

Commits on Dec 18, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Jelle Zijlstra <[email protected]>
    @jonburdo @JelleZijlstra
    jonburdo and JelleZijlstra committed Dec 18, 2022
    1c35610

  2. clean up os.walk comments

    @jonburdo
    jonburdo committed Dec 18, 2022
    73138a6

  3. test correct value in test_walk_above_recursion_limit

    @jonburdo
    jonburdo committed Dec 18, 2022
    2814cc5

  4. set islink and join before loop in os.walk

    @jonburdo
    jonburdo committed Dec 18, 2022
    37f3cc7

Commits on Dec 19, 2022

  1. Merge branch 'main' into iterative-os-walk

    @jonburdo
    jonburdo committed Dec 19, 2022
    d9c766c