gh-100407: [Docs] Improve __subclasshook__
example in abc.rst
#100453
+10
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
There are several changes:
__len__
is no longer there, because old-style iterable protocol does not need it, seecpython/Objects/iterobject.c
Line 76 in 84bc6a4
Foo
is now fully runnable, so people can see what__getitem__
should look likeany("__iter__" in B.__dict__ for B in C.__mro__)
is simplified to behasattr
, much more common and much more pythonic (initial request by @JosephSBoyle)return NotImplemented
here, see https://docs.python.org/3/library/abc.html#abc.ABCMeta.__subclasshook__self.__iter__()
is much better asiter(self)
, calling magic methods directly is not something we should promote in this case. Now it is in sync withFoo.get_iterator()