gh-96290: support partial/invalid UNC drives in normpath() and splitdrive() #100351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barneygale
force-pushed
the
gh-96290-ntpath-normpath-fix
branch
from
471c47b
to
7ab642b
Compare
…splitdrive() This brings the Python implementation of `ntpath.normpath()` in line with the C implementation added in 99fcf15 Co-authored-by: Eryk Sun <[email protected]>
barneygale
force-pushed
the
gh-96290-ntpath-normpath-fix
branch
from
7ab642b
to
1fb70c7
Compare
Almost. The C implementation is incorrect for "UNC" device paths. For example: >>> nt._path_normpath('//?/UNC/server/share/..')
'\\\\?\\UNC\\server'The problem is that it handles "//?/UNC/" as the root instead of "//?/UNC/server/share/". The pure Python implementation gets it right. |
|
I've changed "in line" to "more in line" :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fix handling of partial and invalid UNC drives in
ntpath.splitdrive(), and inntpath.normpath()on non-Windows systems.Paths such as
\\serverand\\are now considered bysplitdrive()to contain only a drive, and consequently are not modified bynormpath()on non-Windows systems. The behaviour ofnormpath()on Windows systems is unaffected, as native OS APIs are used.This brings the Python implementation of
ntpath.normpath()more in line with the C implementation added in 99fcf15.Implementation by @eryksun. I added tests and NEWS.