The Wayback Machine - https://web.archive.org/web/20221223135756/https://github.com/python/cpython/pull/29094
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45464: [doc] Explain that subclassing multiple exceptions is fragile #29094

Merged
merged 4 commits into from Oct 20, 2021

Conversation

ambv
Copy link
Contributor

@ambv ambv commented Oct 20, 2021

This is an alternative to GH-28995 which avoids using a warning box, instead using the recommended affirmative tone. It also provides more details.

https://bugs.python.org/issue45464

@pablogsal
Copy link
Member

pablogsal commented Oct 20, 2021

This reads much better than the other one. I am convinced. I'm closing the other one

Copy link
Member

@pablogsal pablogsal left a comment

LGTM

Left a comment. Thanks a lot for making this PR!

Doc/library/exceptions.rst Outdated Show resolved Hide resolved
ambv and others added 2 commits Oct 20, 2021
Co-authored-by: Pablo Galindo Salgado <[email protected]>
Copy link
Member

@terryjreedy terryjreedy left a comment

This is more detail than I was suggesting, but wording looks fine to me.

@ambv ambv merged commit dff0b71 into python:main Oct 20, 2021
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Oct 20, 2021

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒🤖

@ambv ambv deleted the bpo-45464-multiple-exception-bases branch Oct 20, 2021
@bedevere-bot
Copy link

bedevere-bot commented Oct 20, 2021

GH-29104 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

bedevere-bot commented Oct 20, 2021

GH-29105 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2021
…ile (pythonGH-29094)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
(cherry picked from commit dff0b71)

Co-authored-by: Łukasz Langa <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2021
…ile (pythonGH-29094)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
(cherry picked from commit dff0b71)

Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit that referenced this pull request Oct 20, 2021
…ile (GH-29094) (GH-29104)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
(cherry picked from commit dff0b71)

Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit that referenced this pull request Oct 20, 2021
…ile (GH-29094) (GH-29105)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
(cherry picked from commit dff0b71)

Co-authored-by: Łukasz Langa <[email protected]>
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Oct 21, 2021
* main: (263 commits)
  bpo-45521: Fix a bug in the obmalloc radix tree code. (pythonGH-29051)
  bpo-45522: Allow to disable freelists on build time (pythonGH-29056)
  bpo-34451: Document prompt and output toggle feature in html tutorial (pythonGH-27105)
  bpo-44019: Add operator.call() to __all__ for the operator module (pythonGH-29110)
  bpo-45315: PyType_FromSpec: Copy spec->name and have the type own the memory for its name (pythonGH-29103)
  bpo-44220: Export PyStructSequence_UnnamedField in the limited API (pythonGH-26331)
  bpo-44174: [Enum] add reference to name mangling (pythonGH-29116)
  bpo-45548: add some missing entries to `Modules/Setup` (pythonGH-29115)
  bpo-35673: Add a public alias for namespace package __loader__ attribute (python#29049)
  bpo-45192: Fix a bug that infers the type of an os.PathLike[bytes] object as str (pythonGH-28323)
  bpo-45527: Don't count cache hits, just misses. (pythonGH-29092)
  bpo-45320: Remove long-deprecated inspect methods (pythonGH-28618)
  bpo-41374: Remove obsolete exclusion of netinet/tcp.h on Cygwin (pythonGH-21649)
  bpo-45532: Replace 'default' with 'main' as default in sys.version (pythonGH-29100)
  bpo-45464: [doc] Explain that subclassing multiple exceptions is fragile (pythonGH-29094)
  Cleanup a couple of comments left on PR 28775 post-merge. (pythonGH-29079)
  bpo-45536: Check OpenSSL APIs in configure (pythonGH-29088)
  Add PEPs 593 & 647 to list of PEPs at top of typing docs (pythonGH-29097)
  Add a comment about how to fix bogus test_host_resolution_bad_address failures (python#29085)
  bpo-44525: Specialize simple Python calls. (pythonGH-29033)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants