The Wayback Machine - https://web.archive.org/web/20221219225903/https://github.com/golang/go/pull/57095
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding/json: do not use Buffer when no indent #57095

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

encoding/json: do not use Buffer when no indent #57095

wants to merge 1 commit into from

Conversation

linxiulei
Copy link

@linxiulei linxiulei commented Dec 5, 2022

Using bytes.Buffer is not necessary since we can write the encoded output directly to provided writer.

@gopherbot
Copy link

gopherbot commented Dec 5, 2022

This PR (HEAD: 41b946a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/455277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@linxiulei linxiulei mentioned this pull request Dec 5, 2022
Open
@gopherbot
Copy link

gopherbot commented Dec 5, 2022

Message from Joseph Tsai:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455277.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

gopherbot commented Dec 5, 2022

Message from Eric Lin:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455277.
After addressing review feedback, remember to publish your drafts!

@linxiulei
encoding/json: do not use Buffer when no indent
14d5753 
Using bytes.Buffer is not necessary since we can write the encoded
output directly to provided writer.
@gopherbot
Copy link

gopherbot commented Dec 6, 2022

This PR (HEAD: 14d5753) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/455277 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

gopherbot commented Dec 6, 2022

Message from Daniel Martí:

Patch Set 2: Hold+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/455277.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@linxiulei @gopherbot