The Wayback Machine - https://web.archive.org/web/20221219225903/https://github.com/golang/go/pull/57205
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: use copyBufPool in transferWriter.doBodyCopy() #57205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

net/http: use copyBufPool in transferWriter.doBodyCopy() #57205

wants to merge 1 commit into from

Conversation

mmatczuk
Copy link

@mmatczuk mmatczuk commented Dec 9, 2022

This patch is a followup to 6fd82d8. It applies copyBufPool optimization to transferWriter.doBodyCopy(). The function is very frequently used - everytime Request or Response is written to a wire. Without this patch for every Request and Response processed, if there is a body, we need to allocate and GC a 32k buffer. This is quickly causing GC pressure.

Fixes #57202

net/http: use copyBufPool in transferWriter.doBodyCopy()
ba09cda 
This patch is a followup to 6fd82d8.
It applies copyBufPool optimization to transferWriter.doBodyCopy().
The function is very frequently used - everytime Request or Response is written to a wire.
Without this patch for every Request and Response processed, if there is a body, we need to allocate and GC a 32k buffer.
This is quickly causing GC pressure.

Fixes golang#57202
@gopherbot
Copy link

gopherbot commented Dec 9, 2022

This PR (HEAD: ba09cda) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/456435 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

gopherbot commented Dec 9, 2022

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/456435.
After addressing review feedback, remember to publish your drafts!

@mmatczuk mmatczuk mentioned this pull request Dec 9, 2022
Open
@gopherbot
Copy link

gopherbot commented Dec 9, 2022

Message from Damien Neil:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/456435.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

net/http: transferWriter.doBodyCopy() calls io.Copy() resulting in many buffer allocations
2 participants
@mmatczuk @gopherbot