The Wayback Machine - https://web.archive.org/web/20230307143224/https://github.com/NativeScript/NativeScript/pull/10022
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): page transitions with more flexibility plus modal transitions #10022

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Sep 11, 2022

PR Checklist

What is the current behavior?

Page transitions are limited through their api.

What is the new behavior?

Rich animated page transitions are now possible by giving the developer the full platform API to achieve creative effects. This also addresses several component cases where the transition context would not call the {N} lifecycle however can still allow the layout to participate in the transition context.

closes #6232

@cla-bot cla-bot bot added the cla: yes label Sep 11, 2022
@NathanWalker NathanWalker added this to the 8.4 milestone Sep 11, 2022
@NathanWalker NathanWalker changed the title feat(ios): page transition handling with more flexibility feat(core): page transitions with more flexibility plus modal transitions Sep 29, 2022
@NathanWalker NathanWalker modified the milestones: 8.4, 8.5 Nov 13, 2022
@NathanWalker NathanWalker force-pushed the feat/page-transition-improvements branch 2 times, most recently from 3d4de81 to 03041c2 Compare November 18, 2022 21:38
@NathanWalker NathanWalker force-pushed the feat/page-transition-improvements branch 2 times, most recently from ede1d0b to e178d43 Compare November 25, 2022 04:35
@nx-cloud
Copy link

nx-cloud bot commented Dec 3, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1d6aea2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


Successfully ran 2 targets

Sent with 💌 from NxCloud.

@NathanWalker NathanWalker force-pushed the feat/page-transition-improvements branch 3 times, most recently from 4b932e6 to f0d7373 Compare January 23, 2023 20:09
@NathanWalker NathanWalker force-pushed the feat/page-transition-improvements branch from 9b41aee to a298bb2 Compare February 6, 2023 17:47
@NathanWalker NathanWalker force-pushed the feat/page-transition-improvements branch from a298bb2 to 3b67510 Compare March 3, 2023 03:24
@NathanWalker NathanWalker force-pushed the feat/page-transition-improvements branch from 3b67510 to 62c90e6 Compare March 3, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to customize showModal() transitions
2 participants