The Wayback Machine - https://web.archive.org/web/20221223034316/https://github.com/go-gitea/gitea/pull/21522
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated DSA host key from Docker Container #21522

Merged
merged 5 commits into from Nov 3, 2022

Conversation

xin-u
Copy link
Contributor

@xin-u xin-u commented Oct 20, 2022

Since OpenSSH 7.0 and greater similarly disable the ssh-dss (DSA) public key algorithm, and recommend against its use. http://www.openssh.com/legacy.html

⚠️ BREAKING ⚠️

This patch will remove DSA host key form OpenSSH daemon configuration file.

@silverwind silverwind added this to the 1.19.0 milestone Oct 20, 2022
@silverwind
Copy link
Member

silverwind commented Oct 20, 2022

It's disabled by default in OpenSSH 7.0+ clients, but can still be turned back on.

@xin-u xin-u closed this Oct 23, 2022
@xin-u xin-u deleted the remove-dsa-from-sshd_config branch Oct 23, 2022
@xin-u xin-u restored the remove-dsa-from-sshd_config branch Oct 23, 2022
@xin-u xin-u reopened this Oct 23, 2022
@xin-u xin-u changed the title docker: Remove DSA host key from sshd_config Remove deprecated DSA host key from Docker Container Oct 26, 2022
@xin-u xin-u mentioned this pull request Oct 31, 2022
6543
6543 approved these changes Nov 1, 2022
@lunny
Copy link
Member

lunny commented Nov 3, 2022

make L-G-T-M work

@lunny lunny merged commit f17edfa into go-gitea:main Nov 3, 2022
2 checks passed
@xin-u xin-u deleted the remove-dsa-from-sshd_config branch Nov 3, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 4, 2022
* giteaofficial/main:
  Remove Gusted as Gitea maintainer  (go-gitea#21676)
  Fix token generation when using INTERNAL_TOKEN_URI (go-gitea#21669)
  Clean up formatting on install page (go-gitea#21668)
  Add Webhook authorization header (go-gitea#20926)
  feat: notify doers of a merge when automerging (go-gitea#21553)
  Remove deprecated DSA host key from Docker Container (go-gitea#21522)
  Alter package_version.metadata_json to LONGTEXT (go-gitea#21667)
  Handle branch name with prefix in GitHub migration (go-gitea#20357)
  [skip ci] Updated translations via Crowdin
  Split migrations folder (go-gitea#21549)
@xin-u xin-u added the theme/docker Docker themed issued label Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

7 participants