The Wayback Machine - https://web.archive.org/web/20230112122234/https://github.com/go-gitea/gitea/pull/16643
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting X-FRAME-OPTIONS #16643

Merged

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Aug 6, 2021

This PR provides a mechanism to set the X-FRAME-OPTIONS header.

Fix #7951

Signed-off-by: Andrew Thornton [email protected]

This PR provides a mechanism to set the X-FRAME-OPTIONS header.

Fix go-gitea#7951

Signed-off-by: Andrew Thornton <[email protected]>
@techknowlogick techknowlogick added this to the 1.16.0 milestone Aug 6, 2021
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit

docs/content/doc/advanced/config-cheat-sheet.en-us.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2021

Codecov Report

Merging #16643 (13dc394) into main (067d82b) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #16643   +/-   ##
=======================================
  Coverage   45.41%   45.41%           
=======================================
  Files         756      756           
  Lines       85247    85247           
=======================================
+ Hits        38713    38714    +1     
+ Misses      40271    40270    -1     
  Partials     6263     6263           
Impacted Files Coverage Δ
modules/setting/cors.go 33.33% <ø> (ø)
routers/install/routes.go 45.76% <0.00%> (ø)
routers/web/base.go 17.14% <0.00%> (ø)
modules/context/api.go 73.63% <100.00%> (ø)
modules/context/context.go 60.91% <100.00%> (ø)
modules/charset/charset.go 71.71% <0.00%> (-4.05%) ⬇️
services/pull/pull.go 41.73% <0.00%> (ø)
modules/queue/workerpool.go 53.81% <0.00%> (+0.76%) ⬆️
models/gpg_key_common.go 64.51% <0.00%> (+4.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 067d82b...13dc394. Read the comment docs.

@techknowlogick techknowlogick merged commit afd88a2 into go-gitea:main Aug 6, 2021
2 checks passed
@zeripath zeripath deleted the fix-7951-allow-setting-x-frame-options branch Aug 6, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

Proposal : Permit modification of X-FRAME-OPTIONS headers
5 participants