Return nil proxy function if proxy not enabled #16742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <[email protected]>
|
Please note: As I mentioned #16704 (comment) #16704 is BREAKING as Gitea will now only use a system defined proxy if you actively turn on the proxy service. |
jolheiser
approved these changes
Aug 19, 2021
Codecov Report
@@ Coverage Diff @@
## main #16742 +/- ##
=======================================
Coverage 45.37% 45.37%
=======================================
Files 760 760
Lines 85482 85483 +1
=======================================
+ Hits 38785 38791 +6
+ Misses 40414 40412 -2
+ Partials 6283 6280 -3
Continue to review full report at Codecov.
|
KN4CK3R
approved these changes
Aug 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Unfortunately #16704 contains a bug whereby if the proxy is not enabled all requests fail due to a panic.
This PR sets the proxy function to return a nil function if the proxy is not enabled.
Signed-off-by: Andrew Thornton [email protected]