Improve LDAP synchronization efficiency #16994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current LDAP sync routine has order n^2 efficiency. This change reduces this to order n.log n. Signed-off-by: Andrew Thornton <[email protected]>
|
If we can get the LDAP search and the DB to preorder these things the main algorithm is only order n. |
6543
approved these changes
Sep 10, 2021
lafriks
approved these changes
Sep 15, 2021
Codecov Report
@@ Coverage Diff @@
## main #16994 +/- ##
=======================================
Coverage ? 45.21%
=======================================
Files ? 766
Lines ? 86713
Branches ? 0
=======================================
Hits ? 39203
Misses ? 41158
Partials ? 6352
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The current LDAP sync routine has order n^2 efficiency. This change reduces this
to order n.log n.
Signed-off-by: Andrew Thornton [email protected]