The Wayback Machine - https://web.archive.org/web/20230112145308/https://github.com/go-gitea/gitea/pull/18680
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update assignees check to include any writing team and change org sidebar #18680

Merged
merged 7 commits into from Feb 23, 2022

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Feb 8, 2022

Following the merging of #17811 teams can now have differing write and readonly permissions, however the assignee list will not include teams which have mixed perms.

Further the org sidebar is no longer helpful as it can't describe these mixed permissions situations.

Fix #18572

models/repo.go Show resolved Hide resolved
models/repo.go Show resolved Hide resolved
models/repo.go Outdated Show resolved Hide resolved
models/repo.go Show resolved Hide resolved
models/repo.go Show resolved Hide resolved
lunny
lunny approved these changes Feb 22, 2022
lunny
lunny approved these changes Feb 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

No coverage uploaded for pull request base (main@704bdf8). Click here to learn what that means.
The diff coverage is 73.68%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18680   +/-   ##
=======================================
  Coverage        ?   46.60%           
=======================================
  Files           ?      853           
  Lines           ?   122492           
  Branches        ?        0           
=======================================
  Hits            ?    57085           
  Misses          ?    58515           
  Partials        ?     6892           
Impacted Files Coverage Δ
routers/web/org/teams.go 0.00% <0.00%> (ø)
models/repo.go 53.31% <77.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704bdf8...c45c63f. Read the comment docs.

Signed-off-by: Andrew Thornton <[email protected]>
Gusted
Gusted approved these changes Feb 23, 2022
@zeripath zeripath merged commit cb41f5c into go-gitea:main Feb 23, 2022
2 checks passed
@zeripath zeripath deleted the fix-18572-team-permissions-check branch Feb 23, 2022
zeripath added a commit to zeripath/gitea that referenced this pull request Feb 23, 2022
…ebar (go-gitea#18680)

Backport go-gitea#18680

Following the merging of go-gitea#17811 teams can now have differing write and readonly permissions, however the assignee list will not include teams which have mixed perms.

Further the org sidebar is no longer helpful as it can't describe these mixed permissions situations.

Fix go-gitea#18572

Signed-off-by: Andrew Thornton <[email protected]>
lunny pushed a commit that referenced this pull request Feb 24, 2022
…ebar (#18680) (#18873)

Backport #18680

Following the merging of #17811 teams can now have differing write and readonly permissions, however the assignee list will not include teams which have mixed perms.

Further the org sidebar is no longer helpful as it can't describe these mixed permissions situations.

Fix #18572

Signed-off-by: Andrew Thornton <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 24, 2022
* giteaofficial/main:
  Fix ldap user sync missed email in email_address table (go-gitea#18786)
  Update assignees check to include any writing team and change org sidebar (go-gitea#18680)
  Set max text height to prevent overflow (go-gitea#18862)
  Lock gofumpt to v0.3.0 and run it (go-gitea#18866)
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 25, 2022
…se/v1.16

* giteaofficial/release/v1.16:
  BeforeSourcePath should point to base commit (go-gitea#18880)
  Add changelog for v1.16.2 (go-gitea#18840)
  Fix ldap user sync missed email in email_address table (go-gitea#18786) (go-gitea#18876)
  Don't report signal: killed errors in serviceRPC (go-gitea#18850) (go-gitea#18865)
  Update assignees check to include any writing team and change org sidebar (go-gitea#18680) (go-gitea#18873)
  Fix login with email for ldap users (go-gitea#18800) (go-gitea#18836)
  Fix ldap edit bug (go-gitea#18859)
  Fix ldap loginname (go-gitea#18789) (go-gitea#18804)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
…ebar (go-gitea#18680)

Following the merging of go-gitea#17811 teams can now have differing write and readonly permissions, however the assignee list will not include teams which have mixed perms.

Further the org sidebar is no longer helpful as it can't describe these mixed permissions situations.

Fix go-gitea#18572

Signed-off-by: Andrew Thornton <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

[Bug Report] Team Permission Status
5 participants