The Wayback Machine - https://web.archive.org/web/20220223183950/https://github.com/go-gitea/gitea/pull/16395
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support unprotected file patterns #16395

Merged
merged 14 commits into from Sep 11, 2021
Merged

Support unprotected file patterns #16395

merged 14 commits into from Sep 11, 2021

Conversation

@jpraet
Copy link
Member

@jpraet jpraet commented Jul 10, 2021 •
edited

Fixes #16381.

Note that changes to unprotected files via the web editor still cannot be pushed directly to the protected branch.
I could easily add such support for edits and deletes if needed. But for adding, uploading or renaming unprotected files, it is not trivial.
@6543 6543 added this to the 1.16.0 milestone Jul 10, 2021
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jul 11, 2021 •
edited

Codecov Report

Merging #16395 (3a2572e) into main (77f604a) will increase coverage by 0.03%.
The diff coverage is 40.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16395      +/-   ##
==========================================
+ Coverage   45.21%   45.24%   +0.03%     
==========================================
  Files         766      766              
  Lines       86596    86641      +45     
==========================================
+ Hits        39154    39204      +50     
+ Misses      41103    41093      -10     
- Partials     6339     6344       +5
Impacted Files Coverage Δ
modules/repofiles/delete.go 56.04% <0.00%> (+7.42%) ⬆️
services/auth/source/ldap/source_search.go 46.81% <0.00%> (ø)
services/forms/repo_form.go 41.25% <ø> (ø)
modules/repofiles/update.go 37.20% <11.11%> (-0.67%) ⬇️
models/branches.go 44.33% <29.41%> (-0.39%) ⬇️
services/pull/patch.go 61.27% <35.71%> (+7.03%) ⬆️
routers/private/hook.go 34.68% <45.45%> (+0.23%) ⬆️
modules/git/diff.go 75.26% <75.00%> (-0.05%) ⬇️
modules/convert/convert.go 79.66% <100.00%> (+0.08%) ⬆️
routers/api/v1/repo/branch.go 38.75% <100.00%> (+0.50%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb03e81...3a2572e. Read the comment docs.

jpraet added 2 commits Jul 14, 2021
@jpraet
Merge branch 'master' into unprotected-files
2572221 
# Conflicts:
#	models/migrations/migrations.go
#	models/migrations/v188.go
@jpraet
Merge branch 'master' into unprotected-files
9cb1a6d
6543
6543 reviewed Sep 10, 2021
View changes
services/pull/patch.go Show resolved Hide resolved
6543
6543 approved these changes Sep 11, 2021
View changes
@6543 6543 merged commit 3d6cb25 into go-gitea:main Sep 11, 2021
2 checks passed
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks

@6543 6543

Assignees
No one assigned
Labels
kind/feature lgtm/done
Milestone
1.16.0
Linked issues

Successfully merging this pull request may close these issues.

Support unprotected file patterns
5 participants
@jpraet @codecov-commenter @lafriks @6543 @GiteaBot