Expose resolver via API #15167
Merged
Expose resolver via API #15167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a new field to the API to expose the "resolver" of a comment/
conversation. This is not available in the GitHub API v3.
* Extend struct to contain "Resolver". Might be empty (nil).
* Rename "Reviewer" to "Poster" in PullReviewComment to make it
clear this is the person posting a comment. The API is unchanged
('user').
* Only the first comment of a conversation might have a resolver,
the others seem to be always nil.
|
@sotho build is failing. Not sure why just on pgsql though. |
Codecov Report
@@ Coverage Diff @@
## master #15167 +/- ##
==========================================
+ Coverage 43.38% 43.54% +0.15%
==========================================
Files 668 668
Lines 80620 80621 +1
==========================================
+ Hits 34980 35104 +124
+ Misses 39946 39808 -138
- Partials 5694 5709 +15
Continue to review full report at Codecov.
|
zeripath
reviewed
Mar 27, 2021
zeripath
approved these changes
Mar 27, 2021
6543
approved these changes
Mar 27, 2021
Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
conversation. This is not available in the GitHub API v3.
clear this is the person posting a comment. The API is unchanged
('user').
the others seem to be always nil.