Remove or update bitbucket links #101963
Merged
Remove or update bitbucket links #101963
+6
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zware
reviewed
Feb 16, 2023
| @@ -1908,7 +1908,7 @@ def test_resolve_common(self): | |||
|
|
|||
| @os_helper.skip_unless_symlink | |||
| def test_resolve_dot(self): | |||
| # See https://bitbucket.org/pitrou/pathlib/issue/9/pathresolve-fails-on-complex-symlinks | |||
| # See http://web.archive.org/web/20200623062557/https://bitbucket.org/pitrou/pathlib/issues/9/ | |||
There was a problem hiding this comment.
I'm not sure this comment really adds much; better to just remove it than use an archive link.
There was a problem hiding this comment.
The link was added in the same commit than the unit test so, at least when introduced, it meant something. I don't have a strong opinion about this link but I think it would be better to keep it.
There was a problem hiding this comment.
@serhiy-storchaka, @pitrou Do either of you remember enough context to suggest a replacement for this comment?
There was a problem hiding this comment.
Well, the link shows in which context the test was introduced in the first place. It doesn't hurt to keep it.
sblondon
force-pushed
the
bitbucket-broken-link
branch
3 times, most recently
from
33e61d2
to
532595b
Compare
Since Mercurial removal from bitbucket.org, some links are broken. They are replaced by github.com or webarchive.org links if available. Otherwise, they are removed.
sblondon
force-pushed
the
bitbucket-broken-link
branch
from
532595b
to
d9d90e4
Compare
JulienPalard
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Since Mercurial removal from bitbucket.org, some links are broken.
In this PR, they are replaced by github.com or webarchive links if available. Otherwise, they are removed.
I don't think news are needed (no blurb).