gh-95377: Editted docs for argparse.add_subparser #95490
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PurityLake
force-pushed
the
add-docs-95377
branch
from
3bb4bf4 to
e9f7a26
Compare
PurityLake
force-pushed
the
add-docs-95377
branch
from
e9f7a26 to
ce36799
Compare
iritkatriel
reviewed
Aug 14, 2022
Doc/library/argparse.rst
Outdated
| @@ -1745,10 +1745,12 @@ Sub-commands | |||
| encountered at the command line | |||
|
|
|||
| * dest_ - name of the attribute under which sub-command name will be | |||
| stored; by default ``None`` and no value is stored | |||
| stored; by default ``None`` and no value is stored. Required if | |||
| required_ has been passed | |||
There was a problem hiding this comment.
‘Required if required’ doesn’t read well.
maybe just remove this addition. Is it not enough to document this under ‘required’?
There was a problem hiding this comment.
Apologies for the radio silence, I have removed the line as requested, as yes it isn't needed
cougargt
approved these changes
Feb 5, 2023
PurityLake
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #95377
Added documentation to make it clear that
requiredparameter requiresdestparameter infargparse.add_subparser