gh-102184: Test os.sync() only if "largefile" resource is enabled #102185
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `os.sync()` when the Linux page cache is large and full of dirty pages and the storage device is slow can block the process in "uninterruptible sleep" state for minutes, making the test run unkillable even with SIGKILL. Avoid this by testing `os.sync()` only if "largefile" resource is enabled.
izbyshev
force-pushed
the
expensive-sync
branch
from
2e332c2 to
07adcb3
Compare
There was a problem hiding this comment.
Thank you, it looks like a good idea.
There is also "cpu" resource and new "walltime" resource. "cpu" is disabled by default on CI and in "make test", so it may be better choice than "largefille".
You can also move this test into a separate method and decorate it as bigmemtest. It will be skipped on most buildbots except special buildbots with a large amount of RAM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
os.sync()when the Linux page cache is large and full of dirty pages and the storage device is slow can block the process in "uninterruptible sleep" state for minutes, making the test run unkillable even with SIGKILL. Avoid this by testingos.sync()only if "largefile" resource is enabled.