The Wayback Machine - https://web.archive.org/web/20230301144704/https://github.com/matplotlib/matplotlib/pull/25347
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation for pydata-sphinx-theme 0.13.0 #25347

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix deprecation for pydata-sphinx-theme 0.13.0 #25347

wants to merge 1 commit into from
+3 −2

Conversation

oscargus
Copy link
Contributor

@oscargus oscargus commented Feb 28, 2023 •
edited

PR Summary

Fixes half of #25344

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@oscargus
Copy link
Contributor Author

There are no files images/logo2.svg (but logo2.svg) and images/logo_dark.svg (although I actually had one in my build directory earlier).

This came in through f4a50d3

@jklymak any ideas?

@jklymak
Copy link
Member

jklymak commented Feb 28, 2023

These are part of mpl-sphinx-theme and are at mpl-sphinx-theme/mpl_sphinx_theme/static/images/. They get transferred across as part of the build process to _static/images. Is this not working with 0.13?

@jklymak
Copy link
Member

jklymak commented Feb 28, 2023

This looks to have been changed by pydata/pydata-sphinx-theme#1132. I don't have time right now to dig into how to fix, but I think it needs to be in mpl-sphinx-theme.

jklymak
jklymak requested changes Feb 28, 2023
View changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll block because I think this needs to happen in mpl-sphinx-theme..

@oscargus
Copy link
Contributor Author

Ahh, OK!

I think that maybe the other change is valid, but I will revert the logo-part.

@jklymak
Copy link
Member

jklymak commented Feb 28, 2023

I would just avoid 0.13.0 for now. I'll try to work with them for a fix for 0.13.1

@oscargus
Copy link
Contributor Author

oscargus commented Mar 1, 2023

OK! Guess the deprecation will still be there, so for what it is worth.

@oscargus oscargus changed the title Update for pydata-sphinx-theme 0.13.0 Fix deprecation for pydata-sphinx-theme 0.13.0 Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Documentation: build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oscargus @jklymak