gh-101821: Cover ast.main function
#101822
Open
+20
∄1¤70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, |
arhadthedev
reviewed
Feb 11, 2023
sobolevn
force-pushed
the
issue-101821
branch
from
97969cf
to
a5821a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Couple of comments on the implementation:
script_helper.run_python_until_endhas@support.requires_subprocess()guard, so it is should be safe for envs wheresubprocessis not availableos_helper.temp_diris also widely used for temp files, it even catchesOSErrorand warns about itSo, this new cases should not add any test falkiness or new failures🙂
ast.mainis not covered #101821