The Wayback Machine - https://web.archive.org/web/20220429154731/https://github.com/sveltejs/svelte/pull/5878
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change detected language to TypeScript #5878

Merged
merged 6 commits into from Jan 18, 2021
Merged

change detected language to TypeScript #5878

merged 6 commits into from Jan 18, 2021

Conversation

Copy link
Contributor

@baslr baslr commented Jan 12, 2021

linguist scans the repository and selects the programming language to display.

This PR advises linguist to not look into /site and /test.
Now linguist selects TypeScript.

resolves issue #4284

Test: https://github.com/baslr?tab=repositories&q=svelte&type=&language= https://github.com/baslr/svelte
Bildschirmfoto 2021-01-12 um 23 43 39

Bildschirmfoto 2021-01-13 um 13 27 39

baslr added 2 commits Jan 11, 2021
help linguist to detect typescript as the programming language.
Solves issue sveltejs#4284
@peopledrivemecrazy
Copy link

@peopledrivemecrazy peopledrivemecrazy commented Jan 13, 2021

This is nice but it doesn't detect .svelte files, we do have the orange language flare.

@baslr
Copy link
Author

@baslr baslr commented Jan 13, 2021

@peopledrivemecrazy now it would look like
Bildschirmfoto 2021-01-13 um 13 27 39

.gitattributes Outdated
@@ -0,0 +1,3 @@
/site/** -linguist-detectable
/test/** -linguist-detectable
Copy link
Member

@benmccann benmccann Jan 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can do something like /test/**/samples/** here? I kind of think it makes sense to consider the test code itself, but the samples might make more sense to exclude. That should alter the final results much from what you have now since most of the code is sample code

@benmccann benmccann added the meta label Jan 18, 2021
@benmccann benmccann merged commit dbd184c into sveltejs:master Jan 18, 2021
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants