The Wayback Machine - https://web.archive.org/web/20230304095726/https://github.com/scikit-learn/scikit-learn/pull/25120
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEA add ValidationCurveDisplay in model_selection module #25120

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

glemaitre
Copy link
Contributor

@glemaitre glemaitre commented Dec 6, 2022

Add ValidationCurveDisplay to the model_selection module.

This is the missing curve for the module.

@glemaitre glemaitre marked this pull request as draft December 6, 2022 12:52
@glemaitre glemaitre marked this pull request as ready for review December 6, 2022 13:42
@glemaitre
Copy link
Contributor Author

ping @ArturoAmorQ since this is something that we probably used in the MOOC.

@ArturoAmorQ
Copy link
Member

Don't forget to add the ValidationCurveDisplay to the Display Objects section of the Visualizations module in the User Guide ;)

Copy link
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @glemaitre, this will certainly be a nice addition!
Here are a couple of comments.

doc/modules/learning_curve.rst Outdated Show resolved Hide resolved
doc/whats_new/v1.3.rst Outdated Show resolved Hide resolved
sklearn/model_selection/_plot.py Outdated Show resolved Hide resolved
@jeremiedbb jeremiedbb added this to the 1.3 milestone Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants