#25818 Setting the spine color to white instead of turning them off #25851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had pushed the changes in main branch but later realized it should be done in different branch and then pulled
|
Much as I appreciate your eagerness, I'm concerned that this fix is encouraging the use of a hack workaround. As far as I can tell from the discussion in #25818, best practice here would be to sort out the underlying pixel snapping issue. |
|
I agree with the comment above, but would just like to confirm that you sorted out the branch things just fine! |
|
@Shree7676 the branch looks ok to me, would you like to maybe re-submit with the approach outlined above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
#25818 As per the discussion updated the document also cross verified and its working fine please refer the screenshot
Before :
After :
Note : This is my first contribution, I accidently pushed the changes in main branch but later rectified my mistake by creating a new branch and updating the changes, Hope I have not brooked anything
PR checklist