[Validator] Fix type error for non-array items when Unique::fields is set
#52722
+25
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
changed the title
Unique::fields is set
src/Symfony/Component/Validator/Tests/Constraints/UniqueValidatorTest.php
Outdated
Show resolved
Hide resolved
aprat84
force-pushed
the
fix/unique-validator-error
branch
4 times, most recently
from
7071258
to
7ee329e
Compare
aprat84
force-pushed
the
fix/unique-validator-error
branch
from
7ee329e
to
f7158bd
Compare
xabbuh
reviewed
Nov 27, 2023
| @@ -43,7 +43,7 @@ public function validate(mixed $value, Constraint $constraint) | |||
| $collectionElements = []; | |||
| $normalizer = $this->getNormalizer($constraint); | |||
| foreach ($value as $element) { | |||
| if ($fields && !$element = $this->reduceElementKeys($fields, $element)) { | |||
| if ($fields && !(\is_array($element) && $element = $this->reduceElementKeys($fields, $element))) { | |||
There was a problem hiding this comment.
I wonder if we shouldn't rather throw an UnexpectedValueException instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UniqueValidatorcrashes if:fieldsargument is setvalueis an array but some of the elements are notExample value:
Example constraint config:
Error thrown:
Solution:
Looking at the actual behavior, if one of its items, being an array, has none of the
fields, is ignored.So, continuing on this premise, if one of its items, is not an array, it should be ignored too.
That's what this PR is about (hope so)!