[Cache] Fix Couchbase password parsing #52758
Open
+38
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
couchbase
branch
6 times, most recently
from
fbc9c21
to
1395af4
Compare
| @@ -85,7 +85,7 @@ public static function createConnection($dsn, array $options = []) | |||
| preg_match($dsnPattern, $server, $matches); | |||
|
|
|||
| $username = $matches['username'] ?: $username; | |||
| $password = $matches['password'] ?: $password; | |||
| $password = rawurldecode($matches['password'] ?: $password); | |||
There was a problem hiding this comment.
The issue in this class (and the other) is not only about the password - it's about all URL components.
The fix should involve using parse_url (as done in all other DSN parsers) to let PHP decode everything as needed.
There was a problem hiding this comment.
I updated the DSN parsing with parse_url 👍 I'll try to have a look at other adapters in a separate PR 👍
alexandre-daubois
force-pushed
the
couchbase
branch
4 times, most recently
from
b66e0a7
to
7095459
Compare
alexandre-daubois
force-pushed
the
couchbase
branch
from
7095459
to
ed359c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for PHP 7.2 has been dropped with Couchbase 3.0.5.
This is the followup for #52688 (comment).