Docs: OpenSSL wording ambiguity #113296
Merged
Docs: OpenSSL wording ambiguity #113296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
docs
hugovk
added
skip issue
needs backport to 3.11
|
Yep, looks like a small mistake when changing the versions in that commit: -For example, TLSv1.1 and TLSv1.2 come with openssl version 1.0.1.
+For example, TLSv1.3 with OpenSSL version 1.1.1.Thanks! |
|
Thanks @janbrasna for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 21, 2023
(cherry picked from commit 24f8ff2) Co-authored-by: Jan Brasna <[email protected]>
|
GH-113348 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 21, 2023
(cherry picked from commit 24f8ff2) Co-authored-by: Jan Brasna <[email protected]>
|
GH-113349 is a backport of this pull request to the 3.11 branch. |
hugovk
pushed a commit
that referenced
this pull request
Dec 21, 2023
Co-authored-by: Jan Brasna <[email protected]>
hugovk
pushed a commit
that referenced
this pull request
Dec 21, 2023
Co-authored-by: Jan Brasna <[email protected]>
ryan-duve
pushed a commit
to ryan-duve/cpython
that referenced
this pull request
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial wording improvement. Before
2875c60there was "… comes with…" that I'd suggest having back.Currently the sentence reads as there are some issues with the combination of TLS v1.3 and OpenSSL 1.1.1 as an example, as noted with behavior variations the sentence before.
Maybe it's just puzzling for non-english-speaking reader(?) so feel free to disregard this if it feels right as-is. This is only an attempt to make the message crystal clear.
📚 Documentation preview 📚: https://cpython-previews--113296.org.readthedocs.build/